[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add cufflinks.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] Add cufflinks. |
Date: |
Wed, 16 Sep 2015 19:10:08 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Ricardo Wurmus <address@hidden> skribis:
> From e8186326701df11ee4bdb22d4717cf4b8c27dd50 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Wed, 16 Sep 2015 17:42:41 +0200
> Subject: [PATCH] gnu: Add cufflinks.
>
> * gnu/packages/bioinformatics.scm (boost-1.55, cufflinks): New
> variables.
[...]
> +(define boost-1.55
> + (package (inherit boost)
I would keep it next to ‘boost’.
[...]
> + (lambda* (#:key inputs #:allow-other-keys)
> + ;; The includes for "eigen" are located in a subdirectory.
> + (setenv "CPATH" (string-append (assoc-ref inputs "eigen")
> + "/include/eigen3/" ":"
> + (or (getenv "CPATH") "")))
It should be using ‘pkg-config eigen3 --cflags’, but pkg-config is
missing.
Could you check if adding pkg-config makes this hack unnecessary?
Otherwise LGTM.
Thanks,
Ludo’.