Re: [PATCH] gnu: Add keepassx.

[Mathieu Lirzin]

Efraim Flashner <address@hidden> writes:

> On Wed, 16 Sep 2015 19:33:04 +0200
> Mathieu Lirzin <address@hidden> wrote:
>> [...]
>> Any reason why you don't choose the stable version 0.4.3 ? If it builds
>> correctly on guix, we should use it instead and change the name of this
>> package definition to "keepassx-2".
>

> also building 0.4.3 failed for me with the following error:
> /tmp/nix-build-keepassx-0.4.3.drv-0/keepassx-0.4.3/src/lib/random.cpp: In
> function ?void initStdRand()?:
> /tmp/nix-build-keepassx-0.4.3.drv-0/keepassx-0.4.3/src/lib/random.cpp:98:19:
> error: ?getpid? was not declared in this scope
>   stream << getpid();
>                    ^
> src/CMakeFiles/keepassx.dir/build.make:611: recipe for target
> 'src/CMakeFiles/keepassx.dir/lib/random.cpp.o' failed
> make[2]: *** [src/CMakeFiles/keepassx.dir/lib/random.cpp.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[2]: Leaving directory '/tmp/nix-build-keepassx-0.4.3.drv-0/build'
> CMakeFiles/Makefile2:81: recipe for target 'src/CMakeFiles/keepassx.dir/all'
> failed
> make[1]: *** [src/CMakeFiles/keepassx.dir/all] Error 2
> make[1]: Leaving directory '/tmp/nix-build-keepassx-0.4.3.drv-0/build'
> Makefile:119: recipe for target 'all' failed
> make: *** [all] Error 2
> phase `build' failed after 47 seconds

That's a valid reason.

Pushed in e8647227315653728435ba0673cc2aa690c40138.

Thanks again,

--
Mathieu Lirzin