Re: [PATCH] Add MAFFT.

[Ricardo Wurmus]

Ludovic Courtès <address@hidden> writes:

> Ben Woodcroft <address@hidden> skribis:
>
>> From 0796e8be05977e6d30eab787a1550bd8d1f12b2d Mon Sep 17 00:00:00 2001
>> From: Ben Woodcroft <address@hidden>
>> Date: Sat, 12 Sep 2015 22:10:20 +1000
>> Subject: [PATCH] gnu: Add mafft.
>>
>> * gnu/packages/bioinformatics.scm (mafft): New variable.
>
> I’ll leave it to Ricardo, but two minor comments:

My apologies for the delay.  I flagged this email (along with a couple
of others) as important but it was drowned out by a stream of other
“important” emails... Bleh.

> Maybe not a blocker, but I would really prefer to patterns to be literal
> strings.  If they are too long, we can always split the literal over two
> lines:
>
>     "like \
> this"

I’ve corrected the indentation for the phases and split the string
literals where appropriate instead of using ‘string-append’.

>
>> +   (license (license:non-copyleft "file://license"
>> +                                  "See license in the distribution."))))
>
> I think this should be something like:
>
>   (license (license:non-copyleft
>              "http://mafft.cbrc.jp/alignment/software/license.txt";
>              "BSD-3 with different formatting"))

I replaced the license statement with your suggestion and pushed it.

Thank you, Ben, for the patch and your patience; thank you, Ludo, for
the reviews!

~~ Ricardo