guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] gnu: Add ruby-docile.


From: Pjotr Prins
Subject: Re: [PATCH 1/2] gnu: Add ruby-docile.
Date: Thu, 17 Sep 2015 07:19:27 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Do you mind just editing this patch your way? The description comes
from the package website - I don't feel the urge to improve on it.

Pj.

On Wed, Sep 16, 2015 at 11:39:38AM +0200, Ricardo Wurmus wrote:
> Hi Pjotr,
> 
> > * gnu/packages/ruby.scm (ruby-docile): New variable.
> 
> [...]
> 
> > +    (arguments
> > +     '(#:tests? #f)) ; needs github-markup, among others
> 
> There also is at least one nasty dependency cycle which should be
> mentioned.  A development dependency is ruby-coveralls, which needs
> ruby-simplecov at runtime, which in turn needs ruby-docile at runtime.
> 
> Other dev dependencies are ruby-github-markdown, ruby-redcarpet, and
> ruby-rspec.  (I’ve been working on the same package but went down the
> rabbit hole, depth first.)
> 
> > +    (synopsis "Docile turns any Ruby object into a DSL")
> > +    (description "Turn any Ruby object into a DSL.  Especially useful
> > +with the Builder pattern.  Docile is a small, self-contained Ruby
> > +library, that let's you map a DSL (domain specific language) to your
> > +Ruby objects in a snap.")
> 
> This description is not very helpful, probably because the first two
> sentences are just fragments.  The last sentence is okay, except for the
> “in a snap”, IMO.
> 
> > +    (home-page "https://ms-ati.github.io/docile/";)
> > +    (license license:expat)))
> > +
> >  (define-public ruby-gherkin3
> >    (package
> >      (name "ruby-gherkin3")
> > @@ -1147,3 +1169,4 @@ It is intended to replace Gherkin 2 and be used by 
> > all Cucumber
> >  implementations to parse '.feature' files.")
> >      (home-page "https://github.com/cucumber/gherkin3";)
> >      (license license:expat)))
> > +
> 
> Oh, an additional newline in the middle of “ruby-gherkin3”?  Did
> something go wrong when cutting out the patch amidst other changes?
> 
> ~~ Ricardo
> 

-- 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]