guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] lint: Check non-translated package descriptions.


From: Ludovic Courtès
Subject: Re: [PATCH 1/2] lint: Check non-translated package descriptions.
Date: Tue, 22 Sep 2015 23:36:42 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Mathieu Lirzin <address@hidden> skribis:

> * guix/ui.scm (texi->plain-text): Export.
> * guix/scripts/lint.scm (check-description-style): Use it instead of
>   'package-description-string'.

[...]

> -      (check-texinfo-markup package)
> -      (check-proper-start description)
> -      (check-end-of-sentence-space description))))
> +      (and=> (check-texinfo-markup description)
> +             (lambda (texi)
> +               (check-proper-start texi)
> +               (check-end-of-sentence-space texi))))))

As you suggest, it’s best to keep ‘check-end-of-sentence-space’ before
Texinfo conversion if doing it after would be a no-op.

Could you do that and add a comment above?  OK to push with this change.

Thanks,
Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]