guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/3] gnu: Update python-fixtures


From: Ludovic Courtès
Subject: Re: [PATCH 2/3] gnu: Update python-fixtures
Date: Sun, 27 Sep 2015 22:17:12 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Cyril Roelandt <address@hidden> skribis:

> On 09/22/2015 09:16 PM, Thompson, David wrote:
>> On Mon, Sep 21, 2015 at 6:31 PM, Cyril Roelandt <address@hidden> wrote:
>>> * gnu/packages/python.scm (python-fixtures): Update.
>>> * gnu/packages/python.scm (python-fixtures-0.3.16,
>>>   python2-fixtures-0.3.16, python-pbr-0.11,
>>>   python2-pbr-0.11): New variables.
>>> * gnu/packages/python.scm (python-testrepository): Use 
>>> python-fxitures-0.3.16
>>>   instead of python-fixtures in the inputs.
>> 
>> One package update or new package per patch, please.
>> 
>
> I know it is usually done like this, but I feel this is a bit special,
> since all these changes are only done in order to update
> python-fixtures. I could have:
>
> 1) renamed python-fixtures to python-fixtures-0.3.16 and changed inputs
> from "python-fixtures" to "python-fixtures-0.3.16" for all packages that
> depend on fixtures
> 2) added python-pbr-0.11
> 3) added python-fixtures
> 4) changed inputs from "python-fixtures-0.3.16" to "python-fixtures" for
> all packages that depend on fixtures
>
> But I feel it would be incredibly confusing when looking at "git log". WDYT?

Yeah, two commits would do IMO: one to add python-pbr-0.11, and the
other one for the rest.

Could you do that?  This patch series needs to go in before it
accumulates dust.

Thanks,
Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]