guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: openblas: Fix configure flags on armhf and take target


From: Andreas Enge
Subject: Re: [PATCH] gnu: openblas: Fix configure flags on armhf and take target
Date: Fri, 2 Oct 2015 20:01:07 +0200
User-agent: Mutt/1.5.23 (2014-03-12)

Hi Mark,

On Thu, Oct 01, 2015 at 12:59:51PM -0400, Mark H Weaver wrote:
> It's not your fault, but the fact that (%current-system) returns a
> "system" string (e.g. "mips64el-linux") but (%current-target-system)
> returns a GNU triplet (e.g. "mips64el-unknown-linux-gnu") is very
> confusing.  The fact that we use (or (%current-target-system)
> (%current-system)) in many places, and name variables like the one
> above "system" reinforces that confusion.
> 
> To mitigate this, how about renaming the variable above to
> 'system-or-triplet'?

sorry, your message arrived in my inbox right after I pushed the patch.

> Another possible issue is that our Hurd port seems to use "i586" in
> several places.  I'm not sure if we have to check for that as well.
> Maybe we need a helper procedure to check for Intel systems.

First one would need to know what will happen on hurd, after that, this
might be a good idea.

Andreas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]