guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: sdl-union: Wrap into a procedure and export it.


From: Alex Kost
Subject: Re: [PATCH] gnu: sdl-union: Wrap into a procedure and export it.
Date: Mon, 12 Oct 2015 11:54:41 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Ludovic Courtès (2015-10-11 19:50 +0300) wrote:

> Alex Kost <address@hidden> skribis:
>
>> +(define (sdl-union . sdl-packages)
>> +  "Return 'sdl-union' package that is the union of SDL-PACKAGES.
>> +If SDL-PACKAGES are not specified, all SDL libraries are used."
>> +  (let* ((sdl-packages (if (null? sdl-packages)
>> +                           (list sdl
>> +                                 sdl-gfx
>> +                                 sdl-image
>> +                                 sdl-mixer
>> +                                 sdl-net
>> +                                 sdl-ttf)
>> +                           sdl-packages))
>
> What about writing it like this:
>
>   (define* (sdl-union #:optional (packages (list sdl sdl-gfx …)))
>     …)
>
> That would be more concise and more idiomatic.
>
> If that’s fine with you, OK to push with this change.

Sure, fixed and pushed, thanks !

-- 
Alex



reply via email to

[Prev in Thread] Current Thread [Next in Thread]