Re: [PATCH 1/2] gnu: Add ghc-transformers

[Eric Bavier]

Hello James,

Thanks for the patch.  Comments inline.

On Sun, 11 Oct 2015 22:23:55 +0200
James David Trotter <address@hidden> wrote:

> * gnu/packages/haskell.scm (ghc-transformers): New variable.
> ---
>  gnu/packages/haskell.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)

Could you please add a copyright statement for yourself at the top of
gnu/packages/haskell.scm?

> diff --git a/gnu/packages/haskell.scm b/gnu/packages/haskell.scm
> index 34cad87..33d58f4 100644
> --- a/gnu/packages/haskell.scm
> +++ b/gnu/packages/haskell.scm
> @@ -458,6 +458,30 @@ Haskell software by automating the fetching, 
> configuration, compilation and
>  installation of Haskell libraries and programs.")
>     (license bsd-3)))
>  
> +(define-public ghc-transformers
> +  (package
> +    (name "ghc-transformers")
> +    (version "0.4.3.0")
> +    (outputs '("out" "doc"))

Although other ghc packages in haskell.scm include these two outputs,
the "out" output very often ends up referencing the "doc" output, so
both end up installed in practice, so it should be safe to remove this
field.

> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "http://hackage.haskell.org/package/transformers/transformers-";
> +             version
> +             ".tar.gz"))
> +       (sha256
> +        (base32 "179sbhvc9dghyw58hz80109pbrzgh7vh437227a51jhmx2bsgl5k"))))
> +    (build-system haskell-build-system)
> +    (home-page "http://hub.darcs.net/ross/transformers";)

This is the repository page.  Perhaps the hackage.haskell.org address
would be more appropriate, as many other packages use.  WDYT?

> +    (synopsis "Concrete functor and monad transformers")
> +    (description
> +     "A portable library of functor and monad transformers, inspired by the
> +paper \"Functional Programming with Overloading and Higher-Order
> +Polymorphism\", by Mark P Jones, in Advanced School of Functional 
> Programming,
> +1995 (http://web.cecs.pdx.edu/~mpj/pubs/springschool.html).")

Descriptions can now optionally include texinfo markup, so maybe that
last could be "@url{http://web.cecs.pdx.edu/...}";

> +    (license bsd-3)))
> +
>  (define-public ghc-mtl
>    (package
>      (name "ghc-mtl")

Otherwise looks good.  Could you send an updated patch?

`~Eric