guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add python-statsmodels.


From: Ludovic Courtès
Subject: Re: [PATCH] Add python-statsmodels.
Date: Mon, 19 Oct 2015 17:47:16 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Ricardo Wurmus <address@hidden> skribis:

> the attached patch adds python{,2}-statsmodels to statistics.scm.  Note
> that this depends on my previous patch adding patsy to the same module.

Hmm I lost track of patsy in my inbox.  I’ll check afterwards.

> From 33ddc045065722a0bac9b28ad909e838b169d7cb Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Tue, 13 Oct 2015 13:28:58 +0200
> Subject: [PATCH 1/2] gnu: Add python-statsmodels.
>
> * gnu/packages/statistics.scm (python-statsmodels, python2-statsmodels):
>   New variables.

LGTM.

> +         (add-after 'unpack 'set-matplotlib-backend-to-agg
> +          (lambda _
> +            ;; Set the matplotlib backend to Agg to avoid problems using the
> +            ;; GTK backend without a display.
> +            (substitute* (find-files "statsmodels/graphics/tests" "\\.py")
> +              (("import matplotlib\\.pyplot as plt" line)
> +               (string-append "import matplotlib;matplotlib.use('Agg');"
> +                              line)))

This looks good.  Should we eventually change Matplotlib itself to use
this back-end by default?  What’s at stake exactly?

Thanks!

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]