guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] gnu: Add dosbox x86 emulator.


From: Paul van der Walt
Subject: Re: [PATCH] gnu: Add dosbox x86 emulator.
Date: Thu, 22 Oct 2015 11:13:46 +0200

Hi Mark,

On 2015-10-22 at 00:40, quoth Mark H Weaver:
>> +    (arguments
>> +     `(#:phases (modify-phases %standard-phases
>> +                  (add-before
>> +                   'configure 'autogen.sh
>> +                   (lambda _
>> +                     (zero? (system* "sh" "autogen.sh")))))))
>
> For future reference, phases like the one above, that generates the
> configure script, should always be put after 'unpack' instead of before
> 'configure'.  The reason is that there are some phases between the
> 'unpack' and 'configure' phases that are needed to fix things up in the
> generated 'configure' script for non-Intel platforms, especially
> 'patch-usr-bin-file' which is typically needed on MIPS.
>
> I went ahead and made this change in commit e0a7d36458.

Right, sorry about that, and thank you very much!

p.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]