Re: [PATCH] GCJ: run libjava tests.

[Ludovic Courtès]

Ricardo Wurmus <address@hidden> skribis:

> Ricardo Wurmus <address@hidden> writes:
>
>> Andreas Enge <address@hidden> writes:
>>
>>> On Thu, Oct 22, 2015 at 01:07:25PM +0200, Ricardo Wurmus wrote:
>>>>         ((#:phases phases)
>>>>          `(modify-phases ,phases
>>>> +           (replace 'check
>>>> +            (lambda _ (zero? (system* "make" "check-target-libjava"))))
>>>
>>> Could this be replaced by
>>>    #:test-target "check-target-libjava"
>>> ? Apart from that, your patch looks very useful.
>>
>> Ah, good idea.  I’m trying to build GCJ right now by adding this
>>
>>     ((#:tests? _) #t)
>>     ((#:test-target _) "check-target-libjava")
>>
>> to the ‘substitute-keyword-arguments’ expression instead of replacing
>> the “check” phase.  If this works I’ll push an updated patch.
>
> Sadly, this doesn’t work.  When tests are re-enabled *all* tests are
> run, including tests for g++, no matter what I set as a test target.
>
> I don’t know why.  Do you have any ideas?

‘substitute-keyword-arguments’ only works if the given keyword appears
in the input:

  (substitute-keyword-arguments '()
    ((#:foo _) 'bar))

  => ()

It might be what’s happening here?

Ludo’.