[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/7] guix: git: Support shallow git clones if a tag is availa
From: |
Andy Wingo |
Subject: |
Re: [PATCH 1/7] guix: git: Support shallow git clones if a tag is available |
Date: |
Mon, 26 Oct 2015 07:46:56 +0000 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Hi,
On Sun 25 Oct 2015 21:30, address@hidden (Ludovic Courtès) writes:
> Christopher Allan Webber <address@hidden> skribis:
>
>> Ludovic Courtès writes:
>>
>>> Andy Wingo <address@hidden> skribis:
>>>
>>>> * guix/build/git.scm (git-fetch): Instead of cloning the remote repo, use
>>>> the
>>>> lower-level "init" / "fetch" / "checkout" operations. This lets us make
>>>> a
>>>> shallow checkout if we are checking out a tag.
>>>>
>>>> * guix/git-download.scm (<git-reference>): Add tag field.
>>>> (git-fetch): Support git references with tags but no commits.
>>>
>>> This sounds like a nice improvement. Please move the “This lets us”
>>> sentence to a comment, and drop the newline between entries.
>>
>> This does look like a nice improvement! It seems like it kind of got
>> dropped on the floor. Is there still interest?
>
> Yes! Would you like to look into it? :-)
I can do it :) I just rebased and updated after a couple months, and so
I have the patch fresh :) Sorry for the delay; I am a creature of habit
and using Guix on the machine with that patch broke all my habits :P
Andy