[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/1] gnu: lua: Build with dynamic library support.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH 1/1] gnu: lua: Build with dynamic library support. |
Date: |
Tue, 27 Oct 2015 13:47:04 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Leo Famulari <address@hidden> skribis:
> Notably, this enables the use of dynamic libraries with Lua.
A better subject line for the commit would be:
gnu: lua-5.2: Build shared libraries.
AFAICS, the problem is only with Lua 5.2:
--8<---------------cut here---------------start------------->8---
$ ls $(guix build lua-5.1)/lib
liblua.a liblua.so liblua.so.5.1 lua
$ ls $(guix build lua-5.2)/lib
liblua.a lua pkgconfig
--8<---------------cut here---------------end--------------->8---
Thus I would suggest leaving ‘lua-5.1’ unchanged.
> * gnu/packages/lua.scm (lua, lua-5.1)[arguments]: Set the make flags
> properly for each version of lua.
[...]
> +++ b/gnu/packages/lua.scm
> @@ -24,6 +24,7 @@
> #:use-module (guix packages)
> #:use-module (guix download)
> #:use-module (guix build-system gnu)
> + #:use-module (guix utils)
Looks like this line is not needed, is it?
> #:phases (alist-replace
> 'build
> - (lambda _ (zero? (system* "make" "CFLAGS=-fPIC" "linux")))
> + (lambda _ (zero? (system* "make" "MYCFLAGS=-fPIC" "linux")))
I just tried and AFAICS this line has no effect: Lua 5.2 still lacks
liblua.so. Am I missing something?
> + `(modify-phases ,lua-phases
> + (replace
> + 'build
> + (lambda _
> + (and
> + (zero? (system* "make" (string-append
> + "MYCFLAGS="
> + (string-join '("-fPIC "
> + "-DLUA_USE_LINUX "
> + "MYLIBS=-Wl,-E "
> + "-ldl -lreadline "
> + "-lhistory -lncurses")))
> + "linux")))))))))))
This is in ‘lua-5.1’, so it’s unnecessary AFAICS.
> @@ -89,8 +106,8 @@ for configuration, scripting, and rapid prototyping.")
> version ".tar.gz"))
> (sha256
> (base32
> "0ydxpqkmsn2c341j4r2v6r5r0ig3kbwv3i9jran3iv81s6r6rgjm"))
> - (patches (list (search-patch "luajit-symlinks.patch")
> - (search-patch "luajit-no_ldconfig.patch")))))
> + (patches (list (search-patch "luajit-symlinks.patch")
> + (search-patch "luajit-no_ldconfig.patch")))))
Unnecessary too.
Thanks for looking into it!
Ludo’.
- [PATCH 0/1] lua: Build with dynamic library support, Leo Famulari, 2015/10/26
- [PATCH 1/1] gnu: lua: Build with dynamic library support., Leo Famulari, 2015/10/26
- Re: [PATCH 1/1] gnu: lua: Build with dynamic library support.,
Ludovic Courtès <=
- Re: [PATCH 1/1] gnu: lua: Build with dynamic library support., Leo Famulari, 2015/10/27
- Re: [PATCH 1/1] gnu: lua: Build with dynamic library support., Ludovic Courtès, 2015/10/27
- Re: [PATCH 1/1] gnu: lua: Build with dynamic library support., Leo Famulari, 2015/10/27
- Re: [PATCH 1/1] gnu: lua: Build with dynamic library support., Leo Famulari, 2015/10/28
- Re: [PATCH 1/1] gnu: lua: Build with dynamic library support., Ludovic Courtès, 2015/10/29
- Re: [PATCH 1/1] gnu: lua: Build with dynamic library support., Ludovic Courtès, 2015/10/29