[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 15/15] scripts: Add 'container' subcommand.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH 15/15] scripts: Add 'container' subcommand. |
Date: |
Tue, 27 Oct 2015 18:46:33 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
"Thompson, David" <address@hidden> skribis:
> From f5312c2445d774c9355c947d3c748d064740246e Mon Sep 17 00:00:00 2001
> From: David Thompson <address@hidden>
> Date: Wed, 1 Jul 2015 20:32:07 -0400
> Subject: [PATCH] scripts: Add 'container' subcommand.
>
> * guix/scripts/container.scm: New file.
> * guix/scripts/container/exec.scm: New file.
> * po/guix/POTFILES.in: Add them.
> * Makefile.am (MODULES): Add them.
> * doc/guix.texi (Invoking guix container): New section.
[...]
> +Note: This tool is experimental. The interface is subject to radical
> +change in the future.
Rather:
@quotation Note
As of version @value{VERSION}, this tool is experimental. The ...
@end quotation
The rest looks good to me.
There are no tests, but ‘container-excursion’ is already tested in
tests/containers.scm and exec.scm does little more than call it, so I
think it’s OK.
Thanks!
Ludo’.