Re: [PATCH] Fix and update pbtranscript-tofu.

[Ludovic Courtès]

Ricardo Wurmus <address@hidden> skribis:

> From eec9e45e681b5f2c85db8a5a60a0d55e132e62a1 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Wed, 28 Oct 2015 14:39:13 +0100
> Subject: [PATCH] gnu: pbtranscript-tofu: Update to 2.2.3.
>
> * gnu/packages/bioinformatics.scm (pbtranscript-tofu): Update to 2.2.3.
>   [source]: Remove bundled Cython sources in a snippet.  Drop ".tar.gz"
>   extension from file-name field.
>   [arguments]: Replace "enter-directory-and-clean-up" phase with
>   "enter-directory" phase, and add "patch-setuppy" phase.
>   [inputs]: Add python2-h5py.  Move python2-cython ...
>   [native-inputs]: ... to this field.

[...]

>        (source (origin
>                  (method git-fetch)
>                  (uri (git-reference
>                        (url 
> "https://github.com/PacificBiosciences/cDNA_primer.git";)
>                        (commit commit)))
> -                (file-name (string-append name "-" version ".tar.gz"))
> +                (file-name (string-append name "-" version))

Could you append “-checkout” to the file name, to differentiate it from
the build result?

Otherwise LGTM, thanks!

Ludo’.