Re: [PATCH] Add BLESS

[Ricardo Wurmus]

Alex Kost <address@hidden> writes:

> Ricardo Wurmus (2015-11-06 17:28 +0300) wrote:
>
> [...]
>> I have taken your recipe and removed more bundled sources in a snippet.
>> There’s still bundled stuff that we should get rid of, most importantly
>> kmc, which brings its own executables.
>>
>> I also changed the description based on the paper; instead of patching
>> the Makefile I overwrite the make flags.
>>
>> Attached is a patch.  Does this work for you?
>> What do others think about this patch?
>
> Oops, too late for the comment, but still:
>
> [...]
>> +(define-public bless
>> +  (package
>> +    (name "bless")
>> +    (version "1p02")
>> +    (source (origin
>> +              (method url-fetch)
>> +              (uri (string-append "mirror://sourceforge/bless-ec/bless.v"
>> +                                  version ".tgz"))
>> +              (sha256
>> +               (base32
>> +            "0rm0gw2s18dqwzzpl3c2x1z05ni2v0xz5dmfk3d33j6g4cgrlrdd"))
> tabulation ↑ here
>
>> +                            (modules '((guix build utils)))
> and wrong indentation ↑ here

Ah!  I didn’t see this.  (So embarrassing.)

In both cases it’s tabs.  I copied this whole expression from the
original attachment and it didn’t occur to me to check for tabs as it
looked just right in my Emacs.

What would the correct commit message be to fix this?  Will you fix
this?

~~ Ricardo