Re: [PATCH 0/3] emacs: Improve post processing of popup arguments.

[Alex Kost]

Ludovic Courtès (2015-11-09 00:16 +0300) wrote:

> Alex Kost <address@hidden> skribis:
>
>> Hello, this patchset is for adjusting "M-x guix" for the recent
>> environment/container changes.  'magit-popup' returns a simple list of
>> arguments, and this list needs to be "post-processed".  Previously a
>> very simple post-processing (moving the rest "-- ..." arguments to the
>> end of the arg list) was enough, but now (for a rather complicated 'guix
>> environment' command: positional "--ad-hoc", shell command after '--')
>> it should be improved.  So this is the improvement.
>
> Good catch.
>
>> [PATCH 1/3] emacs: Improve post processing of popup arguments.
>> [PATCH 2/3] emacs: Adjust 'guix container' popup.
>> [PATCH 3/3] emacs: Adjust 'guix environment' popup.
>
> On a cursory look it LGTM.  I don’t grasp the details of #1 but I
> trust you.

OK, thanks, I forgot the details of #1 already :-)  The point was to
make a general final processing of arguments (returned by magit-popup).

> Thank you!

And thank you!  Pushed.

-- 
Alex