Re: [PATCH] doc: Fix 'geiser-guile-load-path' example.

[Alex Kost]

Ludovic Courtès (2015-11-17 19:16 +0300) wrote:

> Alex Kost <address@hidden> skribis:
>
>> Ludovic Courtès (2015-11-15 20:41 +0300) wrote:
>>
>>> Alex Kost <address@hidden> skribis:
>>>
>>>> (add-to-list 'geiser-guile-load-path 'foo) errors if "geiser-guile.el"
>>>> is not loaded yet, so I think it's better to put it inside
>>>> 'with-eval-after-load', WDYT?
>>>
>>> Sounds good.  I guess that’s because (require 'guix-init) doesn’t
>>> require 'geiser?
>>
>> "guix-init.el" shouldn't require geiser.  IMO it should load as less
>> code as possible, because it will increase the Emacs start time.
>>
>> In general I think requiring/loading packages is evil (as it slows down
>> starting Emacs), so I avoid 'require'-s when possible in my init file.
>
> Agreed, I was just making sure I understood the issue at hand.

OK.  Actually I thought that you use 'with-eval-after-load' or
'eval-after-load' or 'use-package', and you just didn't mention it in
the manual because it's a common Emacs thing.  But it looks like you use
a straightforward (add-to-list ...), which can work only if
"geiser-guile.el" is already loaded.  Out of curiosity, do you somehow
load the whole geiser in your emacs config?  If so, why?

I mean not just (require 'geiser), as it does not load
"geiser-guile.el", but maybe (require 'geiser-mode) or something like
it.

(I personally don't touch 'geiser-guile-load-path' at all, I just set
GUILE_LOAD_PATH in my ".bash_profile" instead)

> The patch you sent looks good to me then.

Thanks!

-- 
Alex