guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Export udev-configuration functions.


From: Ricardo Wurmus
Subject: Re: [PATCH] Export udev-configuration functions.
Date: Thu, 19 Nov 2015 17:08:45 +0100
User-agent: mu4e 0.9.13; emacs 24.5.1

Ludovic Courtès <address@hidden> writes:

>> From 77f22cb933a9740cccc62f6bac2d3f9381192eba Mon Sep 17 00:00:00 2001
>> From: Ricardo Wurmus <address@hidden>
>> Date: Wed, 18 Nov 2015 21:58:53 +0100
>> Subject: [PATCH] services: Add udev-rule procedure.
>>
>> * gnu/services/base.scm (udev-rule): New procedure.
>> (kvm-udev-rule): Rewrite in terms of udev-rule.
>
> [...]
>
>> +(define (udev-rule filename contents)
>> +  "Return a directory with a udev rule file FILENAME containing CONTENTS."
>
> Rather “file-name” (sorry for being pedantic ;-)).

Okay.

>> +(define (kvm-udev-rule)
>
> This can even become a plain variable.

Okay!

> Otherwise LGTM!

Thanks.  I pushed it with these two changes.

~~ Ricardo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]