[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCHES] Fix some ‘guix edit’ bad assumptions.
|
From: |
Ludovic Courtès |
|
Subject: |
Re: [PATCHES] Fix some ‘guix edit’ bad assumptions. |
|
Date: |
Tue, 24 Nov 2015 21:48:06 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Mathieu Lirzin <address@hidden> skribis:
> From de988b953de96a17f79d5748541611fbb3d554f9 Mon Sep 17 00:00:00 2001
> From: Mathieu Lirzin <address@hidden>
> Date: Sat, 21 Nov 2015 14:37:54 +0100
> Subject: [PATCH 1/2] edit: Allow command line arguments in $VISUAL and
> $EDITOR.
>
> * guix/scripts/edit.scm (guix-edit): Fix the assumption that %editor is
> a one word command.
[...]
> + (let ((file-names (append-map package->location-specification
> + packages)))
> + (exit (system (string-join (cons (%editor) file-names))))))
Maybe add a comment saying why we use ‘system’ rather than ‘execlp’.
OK with this change, thanks!
Ludo’.