Re: [PATCH 10/10] gnu: Add git-annex-remote-hubic.

[Ricardo Wurmus]

Efraim Flashner <address@hidden> writes:

> +(define-public git-annex-remote-hubic
> +  (package
> +    (name "git-annex-remote-hubic")
> +    (version "0.3.1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://github.com/Schnouki/"; name "/archive/v"
> +                    version ".tar.gz"))
> +              (file-name (string-append name "-" version))

You should also append “.tar.gz”.

> +              (sha256
> +               (base32
> +                "196g3jkaybjx11nbr51n0cjps3wjzb145ab76y717diqvvxp5v4r"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:python ,python-2))
> +    (native-inputs
> +    `(("python2-setuptools" ,python2-setuptools)
> +      ;; some extras for the tests
> +      ("python2-futures" ,python2-futures)
> +      ("python2-six" ,python2-six)))
> +    (inputs
> +     `(("python2-dateutil" ,python2-dateutil)
> +       ("python2-rauth" ,python2-rauth)
> +       ("python2-swiftclient" ,python2-swiftclient)))

These are probably propagated-inputs.

> +    (home-page "https://github.com/Schnouki/git-annex-remote-hubic/";)
> +    (synopsis "Use hubic as a git-annex remote")

I don’t know what “hubic” is but in the description you spell it as
“hubiC”.  Which spelling is correct?

> +    (description
> +     "Git annex remote hubic allows you to use your hubiC account as a 
> \"special
> +repository\".")

I found it difficult to read this description because the first four
words are actually the name of the package.  In this case I’d suggest
replacing “Git annex remote hubic” with the generic “This package”; but
then you should also add “with git-annex” after “special repository”.

~~ Ricardo