[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH]: xfce4-power-manager: new variable
From: |
Florian Paul Schmidt |
Subject: |
Re: [PATCH]: xfce4-power-manager: new variable |
Date: |
Fri, 4 Dec 2015 20:02:22 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
On 12/04/2015 06:16 PM, Andreas Enge wrote:
> On Thu, Dec 03, 2015 at 10:40:50PM +0100, Florian Paul Schmidt
> wrote:
>> Removed some inputs (see attached patch). Seems to still build
>> and run..
>
> I usually work the other way round. I start with empty inputs and
> look at the output of the configure phase, then add inputs one by
> one. This leads to cleaner packages, I think.
>
> Notice that it is not enough to make the binary distinction between
> building and not building. Sometimes optional inputs are useful to
> have (I tend to be maximalist and add as many optional inputs as
> possible).
Yeah, in the current state the basically the only inputs that remain
are those I had to add in the first place to get it to build (the ones
I now removed are leftovers from the original xfce4-related package).
I guess the native-search-path thing might go away safely, too. Will
test and update the patch..
Flo
- --
https://fps.io
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
iQEcBAEBCAAGBQJWYeM+AAoJEA5f4Coltk8ZJFkH/2XZLjsYYgz4fBsvboxTEwVk
DiMb+6pT9pvAkte3nrboeVJn9SVZAogVlSUvhwsDOs3JZC9g52j3u+25kO4whtHU
ah59hUxiflpK9wEdQHEinXnv6ej8VDvbbthg9y2L0LCTmm7Ww49JWNqwLEKnFlND
YaNrzAsjzvPsFGGL5velCD1V+2ukw99Wqlx+0b0cz6bHbRReYsfQk3e6OTkaDBtQ
t4W0pX9jHUZT9/YJmpjid38HACX66QprQTw+3HGcO01VMy8sSJKlFeYIRsvh8xib
zH+ynIitAw150K1yFHZoGHGgGFN6XnxuR0LJs2iQihHkS5sCxcn3sbbR1zqqhuw=
=8Iat
-----END PGP SIGNATURE-----