guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [DMD] [PATCH] service: Change gid before uid when dropping privilege


From: Ludovic Courtès
Subject: Re: [DMD] [PATCH] service: Change gid before uid when dropping privileges.
Date: Fri, 04 Dec 2015 15:27:12 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

David Thompson <address@hidden> skribis:

> Found this little order of operations issue when trying to button up the
> Transmission service.

Indeed, good catch!

> From 552eafe882e3c059525e79c0f222becb9d73eb93 Mon Sep 17 00:00:00 2001
> From: David Thompson <address@hidden>
> Date: Thu, 3 Dec 2015 10:09:34 -0500
> Subject: [PATCH] service: Change gid before uid when dropping privileges.
>

Commit log please.  :-)

Could you send an updated patch?

I think we should also do:

  (setgroups #())

before calling ‘setgid’, and probably factorize exception handling.

Would you like to do that?

Thank you,
Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]