Re: [PATCH 3/3] system: pam: Honor /etc/environment.

[Ludovic Courtès]

宋文武 <address@hidden> skribis:

> * gnu/system/pam.scm (unix-pam-service): Add pam_env module to the session 
> group.

[...]

> +        (env  (pam-entry
> +               (control "required")
> +               (module "pam_env.so"))))

Please mention /etc/environment above.

Otherwise LGTM, thank you!

This patch is OK for now, but we should soon arrange it so that
‘session-environment-service’ extends ‘pam-root-service-type’ in a way
that adds ‘pam_env’ to the session management group of all the PAM
services.

This could be done by extending ‘pam-root-service-type’ with a
procedure.  That procedure would automatically be mapped over all the
PAM services to compute the final PAM services.

The same approach could then be used for pam_elogind.

Thoughts?

Ludo’.