[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/10] gnu: Add python-keystoneclient.
From: |
Ricardo Wurmus |
Subject: |
Re: [PATCH 04/10] gnu: Add python-keystoneclient. |
Date: |
Fri, 11 Dec 2015 15:15:35 +0100 |
Efraim Flashner <address@hidden> writes:
> From 6837ac485125476040469289072e6f59a7139939 Mon Sep 17 00:00:00 2001
> From: Efraim Flashner <address@hidden>
> Date: Mon, 23 Nov 2015 20:29:12 +0200
> Subject: [PATCH 04/10] gnu: Add python-keystoneclient.
> * gnu/packages/openstack.scm (python-keystoneclient)
> (python2-keystoneclient): New variables.
> ---
> gnu/packages/openstack.scm | 73
> +++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 72 insertions(+), 1 deletion(-)
> diff --git a/gnu/packages/openstack.scm b/gnu/packages/openstack.scm
> index 2578292..43f957b 100644
> --- a/gnu/packages/openstack.scm
> +++ b/gnu/packages/openstack.scm
> @@ -19,12 +19,14 @@
> (define-module (gnu packages openstack)
> #:use-module (gnu packages python)
> + #:use-module (gnu packages tls)
> #:use-module (gnu packages version-control)
> #:use-module (guix build-system python)
> #:use-module (guix download)
> #:use-module ((guix licenses)
> #:select (asl2.0))
> - #:use-module (guix packages))
> + #:use-module (guix packages)
> + #:use-module (srfi srfi-1))
> (define-public python-bandit
> (package
> @@ -679,3 +681,72 @@ handling.")
> (define-public python2-oslo.utils
> (package-with-python2 python-oslo.utils))
> +
> +(define-public python-keystoneclient
> + (package
> + (name "python-keystoneclient")
> + (version "1.8.1")
> + (source
> + (origin
> + (method url-fetch)
> + (uri (pypi-uri "python-keystoneclient" version))
> + (sha256
> + (base32
> + "1w4csvkah67rfpxylxnvs2s3594i0f9isy8pf4gnsqs5zirvjaa4"))))
The indentation is a bit off. If this was the only thing I could fix
this before pushing, but I still have some other comments.
> + (build-system python-build-system)
> + (native-inputs
> + `(("python-setuptools" ,python-setuptools)
> + ;; and some packages for the tests
> + ("openssl" ,openssl)
> + ("python-coverage" ,python-coverage)
> + ("python-discover" ,python-discover)
> + ("python-fixtures" ,python-fixtures)
> + ("python-hacking" ,python-hacking)
> + ("python-keyring" ,python-keyring)
> + ("python-lxml" ,python-lxml)
> + ("python-mock" ,python-mock)
> + ("python-mox3" ,python-mox3)
> + ("python-oauthlib" ,python-oauthlib)
> + ("python-oslosphinx" ,python-oslosphinx)
> + ("python-oslotest" ,python-oslotest)
> + ("python-pycrypto" ,python-pycrypto)
> + ("python-requests-mock" ,python-requests-mock)
> + ("python-sphinx" ,python-sphinx)
This doesn’t look like it’s needed for the tests. Maybe you could move
it above the comment (or remove the comment)?
> + ("python-temptest-lib" ,python-tempest-lib)
> + ("python-testrepository" ,python-testrepository)
> + ("python-testresources" ,python-testresources)
> + ("python-testtools" ,python-testtools)
> + ("python-webob" ,python-webob)))
Wow! That’s a very long list of test dependencies. Thanks for your
patience in tracking them down rather than taking the easy route of
disabling tests!
> + (propagated-inputs
> + `(("python-babel" ,python-babel)
> + ("python-debtcollector" ,python-debtcollector)
> + ("python-iso8601" ,python-iso8601)
> + ("python-netaddr" ,python-netaddr)
> + ("python-oslo.config" ,python-oslo.config)
> + ("python-oslo.i18n" ,python-oslo.i18n)
> + ("python-oslo.serialization" ,python-oslo.serialization)
> + ("python-oslo.utils" ,python-oslo.utils)
> + ("python-pbr" ,python-pbr)
> + ("python-prettytable" ,python-prettytable)
> + ("python-requests" ,python-requests)
> + ("python-six" ,python-six)
> + ("python-stevedore" ,python-stevedore)))
> + (home-page "http://www.openstack.org/")
> + (synopsis "Client Library for OpenStack Identity")
> + (description
> + "Python-keystoneclient is the identity service used by OpenStack for
> +authentication (authN) and high-level authorization (authZ). It currently
> +supports token-based authN with user/service authZ, and is scalable to
> support
> +OAuth, SAML, and OpenID in future versions. Out of the box, Keystone uses
> +SQLite for its identity store database, with the option to connect to
> external
> +LDAP.")
I wonder: if it does uses Sqlite by default, how come sqlite is not
among the inputs? Does it bundle sqlite sources? Or does it just fail
by default unless sqlite is installed?
> + (license asl2.0)))
> +
> +(define-public python2-keystoneclient
> + (let ((keystoneclient (package-with-python2 python-keystoneclient)))
> + (package (inherit keystoneclient)
> + (native-inputs
> + `(("python2-oauthlib" ,python2-oauthlib)
> + ,@(alist-delete
> + "python-oauthlib"
> + (package-native-inputs keystoneclient)))))))
Okay!
~~ Ricardo
[PATCH 06/10] gnu: Add python-swiftclient., Efraim Flashner, 2015/12/03
[PATCH 09/10] gnu: Add python2-functools32., Efraim Flashner, 2015/12/03