Re: [PATCH 5/5] gnu: Build lua-5.1 with dynamic library support and a dynamic library.

[Ludovic Courtès]

Leo Famulari <address@hidden> skribis:

> * gnu/packages/lua.scm (lua-5.1)[arguments]: Rewrite make-flags so that
>   Lua is built with platform-specific instructions for shared library
>   loading (dlopen).
> * gnu/packages/patches/lua51-liblua-so.patch: Install liblua.so with
>   execute bit set. Move "-fPIC" flag from patch to package definition.

[...]

> +       #:make-flags (list "PLAT= linux"
> +                          "CFLAGS= -O2 -Wall -fPIC $(MYCFLAGS)"
> +                          "MYLDFLAGS= -fPIC"

Why not just:

  MYCFLAGS=-fPIC

instead of CFLAGS=…?  This would be consistent with how MYLDFLAGS is
used.

> +                          (string-append "INSTALL_TOP= "
> +                                         (assoc-ref %outputs "out"))
> +                          (string-append "INSTALL_MAN= "
> +                                         (assoc-ref %outputs "out")
> +                                         "/share/man/man1"))))))

I’m under the impression that these two variables aren’t needed since
things already get installed in the right place, no?

Thanks,
Ludo’.