Re: [PATCH] gnu: Add python-contextlib2

[Chris Marusich]

Thanks for the response. The module is primarily a backport, but it also contains some features that are not part of the standard library. Therefore, it is not exactly the same as the Python standard library's contextlib module, even in Python 3. Since the module names don't collide, and since I know of at least one project that uses contextlib2 with Python3 [1], I think it'd be good to package it for both Python 2 and Python 3. If you or anyone else has a strong opinion on this, let's talk about it.

[1] I intend to package vcrpy after I package contextlib2, since the former uses the latter: https://github.com/kevin1024/vcrpy/blob/master/setup.py

On Sun, Dec 13, 2015, 15:16 Ludovic Courtès <address@hidden> wrote:

Chris Marusich <address@hidden> skribis:

> On 12/6/15, Ludovic Courtès <address@hidden> wrote:
>> Yes, could you adjust it and send an updated patch?
>>
>
> I've attached the new patch here. I've shortened a few lines,
> including the one requested.

Great.

> In particular, I've shortened every line of the description to 70
> columns. Because of that, it looks like the first line of the
> description will wind up being significantly shorter than 70 chars.
> Are the newlines in the description significant? Or is there some
> reformatting that happens when the description is printed to the
> terminal, e.g. via "guix package --search=foo"?

Yes, there’s reformatting happening here, so don’t worry.  We normally
wrap at 78 columns, as per .dir-locals.el.

>> I must I was a bit confused, partly due to the reply-on-top, which made
>> it more difficult for me to see what you were referring to.  Okay, I was
>> also late for other reasons ;-), but still, I think it’d be great if you
>> could avoid top-posting.
>
> Thanks for pointing this out; I'll reply on the bottom from now on!

Thanks.  :-)

> From 4089b10f384b389999576dfc8766c661a5787a4b Mon Sep 17 00:00:00 2001
> From: Chris Marusich <address@hidden>
> Date: Mon, 7 Dec 2015 21:07:40 -0800
> Subject: [PATCH] gnu: Add python-contextlib2.
>
> * gnu/packages/python.scm (python-contextlib2, python2-contextlib2):
>   New variables.

[...]

> +    (home-page "http://contextlib2.readthedocs.org/")
> +    (synopsis "Tools for decorators and context managers")
> +    (description "This module is primarily a backport of the Python
> +3.2 contextlib to earlier Python versions.  Like contextlib, it
> +provides utilities for common tasks involving decorators and context
> +managers.  It also contains additional features that are not part of
> +the standard library.")
> +    (license psfl)))
> +
> +(define-public python2-contextlib2
> +  (package-with-python2 python-contextlib2))

IIUC the description it only makes sense for Python 2.x, right?

In that case, could you add an explicit #:python in ‘arguments’ and keep
only the 2.x variant?  I could do that for you if you prefer.

Thanks, and sorry for the delay!

Ludo’.