[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/4] gnu: samba: Update to 4.3.2.
|
From: |
宋文武 |
|
Subject: |
Re: [PATCH 4/4] gnu: samba: Update to 4.3.2. |
|
Date: |
Fri, 18 Dec 2015 10:31:36 +0800 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
address@hidden (Ludovic Courtès) writes:
> 宋文武 <address@hidden> skribis:
>
>> * gnu/packages/samba.scm (samba): Update to 4.3.2. Add more inputs.
>> [arguments]: Use 'modify-phases' syntax.
>
> Please mention the arguments removed (#:modules and #:imported-modules)
> and the phases removed.
>
> Otherwise LGTM.
Done, thanks for the review!
> Besides, I wonder if we should change it to ‘waf-build-system’.
All things from samba projects (tevent, ldb, etc.) use a custom
configure script to run its own “buildtools/bin/waf”. And
waf-build-system expect “waf” and “wscript” in the same toplevel
folder, so it won’t work.