[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/1] doc: Explain significance of partition labels.
|
From: |
Leo Famulari |
|
Subject: |
Re: [PATCH 1/1] doc: Explain significance of partition labels. |
|
Date: |
Sun, 20 Dec 2015 23:29:16 -0500 |
|
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Sun, Dec 20, 2015 at 11:16:04PM +0100, Ludovic Courtès wrote:
> Leo Famulari <address@hidden> skribis:
>
> > * doc/guix.texi (Preparing for Installation): Point out relationship
> > between partition labels and the file-system configuration.
>
> [...]
>
> > +Be sure that your partition labels match the value of their respective
> > address@hidden fields in your @code{file-system} configuration, if your
> > address@hidden configuration sets the value of @code{title} to
> > +"label", as do the example configurations found on the USB installation
>
> @code{'label}
>
> > +image under @code{/etc/configuration} (@pxref{Using the Configuration
>
> @file{/etc/configuration}
>
> Otherwise LGTM!
I fixed those.
> I’ve noticed a number of people who had overlooked the comment in the
> configuration examples, so this is a worthy addition.
>
> I wonder if changing the label in the examples from “root” to
> “my-root-partition” or similar wouldn’t make it less easily overlooked?
Done in the updated patch.
>
> Thanks,
> Ludo’.