Re: [PATCH] Add package definition for GNU XaoS.

[Alex Kost]

Andreas Enge (2015-12-16 04:48 +0300) wrote:

> Maybe it would make sense to kindly remind them to put their releases
> on ftp.gnu.org. That would also allow us to be notified of updates
> (which could be used as an argument).

I was going to commit this patch but now I don't know: should we wait
for a reply from the maintainers about updating xaos release on gnu.org?
Or maybe push this patch now, and change the origin URL later (if there
will be a response)?

Fabian Harfert (2015-12-15 23:02 +0300) wrote:

[...]
> From 6687ea7c21725bdc13e368773d5c7576a43db14e Mon Sep 17 00:00:00 2001
> From: Fabian Harfert <address@hidden>
> Date: Tue, 15 Dec 2015 21:00:38 +0100
> Subject: [PATCH] Add package definition for GNU XaoS.

Our convention is to use the following commit message:

--8<---------------cut here---------------start------------->8---
gnu: Add xaos.

* gnu/packages/maths.scm (xaos): New variable.
--8<---------------cut here---------------end--------------->8---

> ---
>  gnu/packages/maths.scm | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
>
> diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
> index 0c0f013..181809c 100644
> --- a/gnu/packages/maths.scm
> +++ b/gnu/packages/maths.scm
> @@ -9,6 +9,7 @@
>  ;;; Copyright © 2015 Sou Bunnbu <address@hidden>
>  ;;; Copyright © 2015 Mark H Weaver <address@hidden>
>  ;;; Copyright © 2015 Efraim Flashner <address@hidden>
> +;;; Copyright © 2015 Fabian Harfert <address@hidden>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -53,6 +54,7 @@
>    #:use-module (gnu packages ghostscript)
>    #:use-module (gnu packages glib)
>    #:use-module (gnu packages gtk)
> +  #:use-module (gnu packages image)

Our (gnu packages image) module uses (gnu packages maths).  I wouldn't
add this circularity, I think it was better to have xaos in a separate
module.  But actually I don't know if it's a real issue and what our
policy on such things is.  I hope more experienced guix/guile people
will tell if we should avoid such circularities.

-- 
Alex