Re: New package: xmlstarlet

[Raimon Grau]

Ricardo Wurmus writes:

> Hi Raimon,
>
> thanks for your patch!  Did you use “guix lint xmlstarlet”?
>

Yes I did use it. I had some issues running it in a guix checkout, but
eventually got to run it:
http://puntoblogspot.blogspot.com.es/2015/12/linting-guix-packages.html

>> From 592e889da41a92f029526283c7c837cd426f21cb Mon Sep 17 00:00:00 2001
>> From: Raimon Grau <address@hidden>
>> Date: Mon, 28 Dec 2015 11:51:59 +0000
>> Subject: [PATCH] gnu: Add xmlstarlet.
>
>> * gnu/packages/xml.scm (xmlstarlet): New variable.
>> ---
>>  gnu/packages/xml.scm | 30 ++++++++++++++++++++++++++++++
>>  1 file changed, 30 insertions(+)
>
>> diff --git a/gnu/packages/xml.scm b/gnu/packages/xml.scm
>> index 8288869..5309aea 100644
>> --- a/gnu/packages/xml.scm
>> +++ b/gnu/packages/xml.scm
>> @@ -6,6 +6,7 @@
>>  ;;; Copyright © 2015 Ricardo Wurmus <address@hidden>
>>  ;;; Copyright © 2015 Mark H Weaver <address@hidden>
>>  ;;; Copyright © 2015 Efraim Flashner <address@hidden>
>> +;;; Copyright © 2015 Raimon Grau <address@hidden>
>>  ;;;
>>  ;;; This file is part of GNU Guix.
>>  ;;;
>> @@ -707,3 +708,32 @@ Cflags: -I${includedir}
>>  C++ programming langauge.")
>>      (home-page "http://www.grinninglizard.com/tinyxml/index.html";)
>>      (license license:zlib)))
>> +
>> +(define-public xmlstarlet
>> + (package
>> +   (name "xmlstarlet")
>> +   (version "1.6.1")
>> +   (source
>> +    (origin
>> +      (method url-fetch)
>> +      (uri (string-append
>> +            "http://downloads.sourceforge.net/project/xmlstar/xmlstarlet/";
>> +            version
>> +            "/xmlstarlet-"
>> +            version
>> +            ".tar.gz"))
>
> You might be able to use “mirror://sourceforge/” instead.  I also think
> it looks nicer to have fewer lines here, e.g.:
>
>          (uri (string-append "mirror://sourceforge/xmlstar/xmlstarlet/"
>                              version "/xmlstarlet-" version ".tar.gz"))
>

Thanks, fixed.

>> +      (sha256
>> +       (base32
>> +        "1jp737nvfcf6wyb54fla868yrr39kcbijijmjpyk4lrpyg23in0m"))))
>> +   (build-system gnu-build-system)
>> +   (inputs
>> +    `(("libxslt" ,libxslt)
>> +      ("libxml2" ,libxml2)))
>> +   (home-page "http://xmlstar.sourceforge.net/";)
>> +   (synopsis "Command line XML Toolkit")
>
> “toolkit” rather than “Toolkit”.  But maybe there’s a better synopsis
> that tells us a little more about the tools?  (I cannot suggest anything
> better.)
>
>> +   (description "XMLStarlet is a set of command line utilities (tools)
>> +which can be used to transform, query, validate, and edit XML
>> +documents and files using simple set of shell commands in similar way
>> +it is done for plain text files using UNIX grep, sed, awk, diff,
>> +patch, join, etc commands.")
>
> This is a little hard to read and the comparison with coreutils isn’t
> very helpful (what does this really mean?).  I’d write the first
> sentence like this:
>
>   "XMLStarlet is a set of command line utilities which can be used to
>    transform, query, validate, and edit XML documents."
>
> And then add another sentence about the commands.  Note that there
> should be two spaces between sentences.

I agree the comparison with coreutils is not very easy to understand,
but it's how the package is defined in its home page
(http://xmlstar.sourceforge.net/overview.php).

As a '2nd sentence' the home page says:

"This set of command line utilities can be used by those who deal with many XML
 documents on UNIX shell command prompt as well as for automated XML processing
 with shell scripts."

Which is not very clear either.

I'm attaching the modified version with all but the description change,
in case anyone knows how to reword it and integrate it already. If not,
any suggestions?

Cheers,

Rai

0001-gnu-Add-xmlstarlet.patch
Description: Text Data