Re: [PATCH] gnu: Add slurm

[Eric Bavier]

Hello,

Welcome, and thanks for the patch.

> If okay I would like to avoid providing my legal name.

Using a pseudonym is fine.

On Mon, 28 Dec 2015 23:00:14 +0100
address@hidden wrote:

>  gnu/packages/networking.scm | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)

Please see the manual and `git log' for examples of proper commit
messages.

> diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
> index 0a7cde0..d84551d 100644
> --- a/gnu/packages/networking.scm
> +++ b/gnu/packages/networking.scm
> @@ -3,6 +3,7 @@
>  ;;; Copyright © 2015 Ricardo Wurmus <address@hidden>
>  ;;; Copyright © 2015 Mark H Weaver <address@hidden>
>  ;;; Copyright © 2015 Stefan Reichör <address@hidden>
> +;;; Copyright © 2015 swedebugia <address@hidden>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -187,3 +188,23 @@ needed/wanted real-time traffic statistics of multiple 
> network
>  interfaces, with a simple and efficient view on the command line.  It is
>  intended as a substitute for the PPPStatus and EthStatus projects.")
>      (license license:gpl2+)))
> +
> +(define-public slurm
> +  (package
> +    (name "slurm")

Aside: It's too bad the name clashes with SLURM the work-load manager,
but we can use the name "slurm-wlm" for that (like debian) when it's
packaged.

> +    (version "0.4.3")
> +    (source
> +     (origin
> +      (method url-fetch)
> +      (uri (string-append 
> "https://github.com/mattthias/slurm/archive/upstream/";
> +                          version ".tar.gz"))
> +      (sha256
> +       (base32
> +        "1b53sckvg1j8510gi4bc48q61191jcc1nvhp5k8f2ywj2p9c0q5r"))))
> +    (build-system gnu-build-system)
> +     (inputs `(("ncurses" ,ncurses)

Align the opening parentheses with the previous.

> +    (home-page "https://github.com/mattthias/slurm";)
> +    (synopsis "yet another network load monitor")

Perhaps just "Network load monitor"

> +    (description
> +     "slurm is a generic network load monitor for *BSD, Linux, HP-UX and 
> Solaris. It features 3 graph modes with curses ascii graphics, traffic 
> statistics and works on any interface supported by the kernel.")
> +    (license gpl2+)))

Finally, please execute "guix lint slurm" and fix the issues reported
there.

`~Eric