Re: [PATCH] gnu: Add slurm

[Leo Famulari]

On Mon, Dec 28, 2015 at 11:00:14PM +0100, address@hidden wrote:
> My first patch ever to a software project. How did I do?

Thanks for your first patch! However, it has some problems that will
need to be fixed.

Did you follow all the steps described in the manual under
"Contributing"?

Please read that section, and make the necessary changes to the patch.

Here are the basic steps to get started, assuming you have installed
Guix from the binary tarball, on another distro:

0) Clone the Guix git repo.
1) Build Guix from the git repo.
   `guix environment guix`
   `./bootstrap && ./configure --localstatedir=/var && make`
   Be careful about the value of '--localstatedir'. '/var' is the
   default value if you installed from the Guix binary.
2) Lint your package.
   `./pre-inst-env guix lint slurm`
3) Build the package.
   `./pre-int-env guix build slurm`
4) Finally, you should test that the software provided by the package
   works as expected.
   `./pre-inst-env guix environment --ad-hoc slurm`
   That will put the Guix-provided slurm in your path for you try out.
5) Format and send the patch. Check `git log` for examples of how to
   write commit messages in the desired format.

Hopefully those steps are complete. I wrote them from memory.

> If okay I would like to avoid providing my legal name.

I think that's fine. There is at least one other contributor with the
same preference.

Feel free to ask for help on IRC.

> From 53832a06a61801e9996252506aacad468d54f071 Mon Sep 17 00:00:00 2001
> From: swedebugia <address@hidden>
> Date: Mon, 28 Dec 2015 15:04:21 +0100
> Subject: [PATCH] gnu: Add slurm
> 
> ---
>  gnu/packages/networking.scm | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
> index 0a7cde0..d84551d 100644
> --- a/gnu/packages/networking.scm
> +++ b/gnu/packages/networking.scm
> @@ -3,6 +3,7 @@
>  ;;; Copyright ?? 2015 Ricardo Wurmus <address@hidden>
>  ;;; Copyright ?? 2015 Mark H Weaver <address@hidden>
>  ;;; Copyright ?? 2015 Stefan Reich??r <address@hidden>
> +;;; Copyright ?? 2015 swedebugia <address@hidden>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -187,3 +188,23 @@ needed/wanted real-time traffic statistics of multiple 
> network
>  interfaces, with a simple and efficient view on the command line.  It is
>  intended as a substitute for the PPPStatus and EthStatus projects.")
>      (license license:gpl2+)))
> +
> +(define-public slurm
> +  (package
> +    (name "slurm")
> +    (version "0.4.3")
> +    (source
> +     (origin
> +      (method url-fetch)
> +      (uri (string-append 
> "https://github.com/mattthias/slurm/archive/upstream/";
> +                          version ".tar.gz"))
> +      (sha256
> +       (base32
> +        "1b53sckvg1j8510gi4bc48q61191jcc1nvhp5k8f2ywj2p9c0q5r"))))
> +    (build-system gnu-build-system)
> +     (inputs `(("ncurses" ,ncurses)
> +    (home-page "https://github.com/mattthias/slurm";)
> +    (synopsis "yet another network load monitor")
> +    (description
> +     "slurm is a generic network load monitor for *BSD, Linux, HP-UX and 
> Solaris. It features 3 graph modes with curses ascii graphics, traffic 
> statistics and works on any interface supported by the kernel.")
> +    (license gpl2+)))
> -- 
> 1.9.1
> 

[0]
https://www.gnu.org/software/guix/manual/html_node/Contributing.html