guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] guix: build-system: python: Add an optional argument EXTENSI


From: Eric Bavier
Subject: Re: [PATCH] guix: build-system: python: Add an optional argument EXTENSION to pypi-uri
Date: Wed, 06 Jan 2016 12:31:51 -0600
User-agent: Roundcube Webmail/1.0.6

On 2016-01-06 11:21, address@hidden wrote:
I corrected as suggested by cyril and efraim.

I hope it is acceptable now.
--- a/guix/build-system/python.scm
+++ b/guix/build-system/python.scm
@@ -41,12 +41,15 @@
 ;;
 ;; Code:

-(define (pypi-uri name version)
+(define* (pypi-uri name version
+                   #:optional
+                   (extension ".tar.gz"))
"Return a URI string for the Python package hosted on the Python Package
-Index (PyPI) corresponding to NAME and VERSION."
+Index (PyPI) corresponding to NAME, VERSION and EXTENSION which defaults to
+'.tar.gz' as most packages in the archive has this extension."

s/has/have/

Otherwise LGTM.

--
`~Eric



reply via email to

[Prev in Thread] Current Thread [Next in Thread]