Re: [PATCH] Add 17 moar rubygems.

[Ricardo Wurmus]

Ben Woodcroft <address@hidden> writes:

> These packages are independent of the other 12 submitted packages, 
> except for ruby-ansi which has already been reviewed - I've attached an 
> updated patch that incorporates your comments, thanks Ricardo.

Thank you.  I’ve just pushed this version of ruby-ansi.

> From 052e3fa15dced49faebc51b74ddc2a550713b569 Mon Sep 17 00:00:00 2001
> From: Ben Woodcroft <address@hidden>
> Date: Wed, 30 Dec 2015 23:19:10 +1000
> Subject: [PATCH 02/18] gnu: Add ruby-turn.

> * gnu/packages/ruby.scm (ruby-turn): New variable.

Okay!

> From 4c14a6323d29d772ab688dcd895870edec3fe5dc Mon Sep 17 00:00:00 2001
> From: Ben Woodcroft <address@hidden>
> Date: Wed, 30 Dec 2015 23:22:05 +1000
> Subject: [PATCH 03/18] gnu: Add ruby-ruby-minitest-focus.

> * gnu/packages/ruby.scm (ruby-ruby-minitest-focus): New variable.

There’s one “ruby-” too much here and in the summary.

> +    (description
> +     "@code{minitest-focus} gives the ability focus on a few tests with ease
> +without having to use command-line arguments.  It introduces a @code{focus}
> +class method that specifies the next test defined is to be run.")

“the ability [to] focus on”.  The second sentence doesn’t make sense to
me; something’s wrong about it.  In general I find this description to
be rather unclear.

> +    (home-page
> +     "https://github.com/seattlerb/minitest-focus";)

Please put this on one line.

> From a29ccdea723bfeede027faf0e85b906900e53f39 Mon Sep 17 00:00:00 2001
> From: Ben Woodcroft <address@hidden>
> Date: Wed, 30 Dec 2015 23:36:03 +1000
> Subject: [PATCH 04/18] gnu: Add ruby-minitest-pretty-diff.

> * gnu/packages/ruby.scm (ruby-minitest-pretty-diff): New variable.

[...]

> +(define-public ruby-minitest-pretty-diff
> +  ;; Use git reference because gem is out of date and does not contain 
> testing
> +  ;; script. There are no releases on GitHub.
               ^  Please add one more space here.

> +  (let ((revision "1")
> +        (commit "11f32e930f574225432f42e5e1ef6e7471efe572"))
> +    (package
> +      (name "ruby-minitest-pretty-diff")
> +      (version (string-append "0.1." revision "." commit))

I think when the full commit is used it should be truncated to <10
characters with

    (string-take commit 9)

I’m a little uncomfortable about the “revision” part (even though I’ve
been using it as well); I would like to have a better way to separate
the actual version from our custom version strings.  What do we do when
upstream decides to use three digit version numbers like “0.1.1”?  Will
this correctly be considered an update over “0.1.2.cafebabe” with a
revision of 2?

We can leave this for now, but I’d like to find a better solution in
general.

> +      (home-page
> +       "https://github.com/adammck/minitest-pretty_diff";)

On one line please.

> From 22645c2c465c4cc5554409832b16c85ee1f320aa Mon Sep 17 00:00:00 2001
> From: Ben Woodcroft <address@hidden>
> Date: Thu, 31 Dec 2015 07:30:37 +1000
> Subject: [PATCH 05/18] gnu: Add ruby-ruby-minitest-moar.

> * gnu/packages/ruby.scm (ruby-ruby-minitest-moar): New variable.

Again one “ruby-” too much here.  (Or maybe it’s appropriate considering
the gem name contains “moar”...)

> +    (home-page
> +     "https://github.com/dockyard/minitest-moar";)

Same as above.

I think I need a break.  Any takers for the remaining patches? :)

~~ Ricardo