Re: [PATCH 15/17] gnu: Update python-tzlocal to 1.2.

[Leo Famulari]

On Wed, Jan 06, 2016 at 09:14:26PM +0200, Efraim Flashner wrote:
> On Sun,  3 Jan 2016 19:05:13 -0500
> Leo Famulari <address@hidden> wrote:
> 
> > * gnu/packages/python.scm (python-tzlocal): Update to 1.2.
> > [source]: Use pypi-uri.
> > [arguments]: Remove the custom 'unpack phase.
> > [native-inputs]: Remove unzip, python-setuptools.
> > [propagated-inputs]: Add python-pytz.
> > ---
> >  gnu/packages/python.scm | 23 ++++-------------------
> >  1 file changed, 4 insertions(+), 19 deletions(-)
> > 
> > diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> > index fca11c1..4af9354 100644
> > --- a/gnu/packages/python.scm
> > +++ b/gnu/packages/python.scm
> > @@ -1014,31 +1014,16 @@ doing practical, real world data analysis in 
> > Python.")
> >  (define-public python-tzlocal
> >    (package
> >      (name "python-tzlocal")
> > -    (version "1.1.1")
> > +    (version "1.2")
> >      (source
> >       (origin
> >        (method url-fetch)
> > -      (uri (string-append "https://pypi.python.org/packages/source/t/";
> > -                          "tzlocal/tzlocal-" version ".zip"))
> > +      (uri (pypi-uri "tzlocal" version))
> >        (sha256
> >         (base32
> > -        "1m3y918c3chf41fwg2bx4w42bqsjzn3dyvvcmwwy13c8gj6zssv9"))))
> > +        "12wsw2fl3adrqrwghasld57bhqdrzn0crblqrci1p5acd0ni53s3"))))
> >      (build-system python-build-system)
> > -    (native-inputs
> > -     `(("unzip" ,unzip)
> > -       ("python-setuptools" ,python-setuptools)))
> > -    (inputs `(("python-pytz" ,python-pytz)))
> > -    (arguments
> > -     `(#:phases
> > -       (alist-replace
> > -        'unpack
> > -        (lambda _
> > -          (let ((unzip (string-append (assoc-ref %build-inputs "unzip")
> > -                                      "/bin/unzip"))
> > -                (source (assoc-ref %build-inputs "source")))
> > -            (and (zero? (system* unzip source))
> > -                 (chdir (string-append "tzlocal-" ,version)))))
> > -        %standard-phases)))
> > +    (propagated-inputs `(("python-pytz" ,python-pytz)))
> >      (home-page "https://github.com/regebro/tzlocal";)
> >      (synopsis
> >       "Local timezone information for Python")
> 
> This one looks good to me

Agreed, it's nice to get rid of all that.

> 
> -- 
> Efraim Flashner   <address@hidden>   אפרים פלשנר
> GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
> Confidentiality cannot be guaranteed on emails sent or received unencrypted