guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add fxtract.


From: Ben Woodcroft
Subject: Re: [PATCH] Add fxtract.
Date: Tue, 12 Jan 2016 07:53:10 +1000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0



On 12/01/16 07:00, Ludovic Courtès wrote:
Ben Woodcroft <address@hidden> skribis:

 From acd310d27c457139d3f2fcd2cfc1127167bf2c48 Mon Sep 17 00:00:00 2001
From: Ben Woodcroft <address@hidden>
Date: Thu, 7 Jan 2016 07:44:58 +1000
Subject: [PATCH] gnu: Add fxtract.

* gnu/packages/bioinformatics.scm (fxtract): New variable.
[...]

+       `(("ctskennerton-util"
+          ,(origin
+             (method git-fetch)
+             (uri (git-reference
+                   (url "https://github.com/ctSkennerton/util.git";)
+                   (commit util-commit)))
This is GPLv2-only.  Could you mention it in a comment?

+             (file-name (string-append
+                         "ctstennerton-util-" util-commit "-checkout"))
I would make it:

   (string-append "ctstennerton-util-" (string-take util-commit 7)
                  "-checkout")

+      (home-page "https://github.com/ctSkennerton/fxtract";)
+      (synopsis "Extract sequences from FASTA and FASTQ files")
+      (description
+       "Fxtract extracts sequences from a protein or nucleotide fastx (FASTA
+or FASTQ) file given a subsequence.  It uses a simple substring search for
+basic tasks but can change to using POSIX regular expressions, PCRE, hash
+lookups or multi-pattern searching as required.  By default fxtract looks in
+the sequence of each record but can also be told to look in the header,
+comment or quality sections.")
+      (license license:gpl3+))))
According to the ‘LICENSE’ file, this should be ‘license:expat’.

Otherwise LGTM.

Pushed with these changes. Thanks for picking up the mistakes.

ben



reply via email to

[Prev in Thread] Current Thread [Next in Thread]