Re: [PATCHES] Update orfm and package test requirements.

[Ricardo Wurmus]

Ben Woodcroft <address@hidden> writes:

>>     “Bio-comandeer lets you run shell commands from within Ruby.  ...”
> That wasn't the best sentence before, fo so. I wonder if the replacement 
> is a little bland though. How about (as attached),
>
> +     "Bio-commandeer provides an opinionated method of running shell 
> commands
> +from within Ruby.  The advantage of bio-commandeer over other methods of
> +running external commands is that when something goes wrong, the 
> @code{STDOUT}
> +and @code{STDERR} are reported, giving extra detail to ease debugging.")

This is almost okay, I think.  I would add a couple of words to state
that messages or text *printed* to STDOUT/STDERR (rather than the
streams themselves) are reported.

> From b7d92cbfd47fa9f4807ea72d570d703b78fb59f7 Mon Sep 17 00:00:00 2001
> From: Ben Woodcroft <address@hidden>
> Date: Sat, 21 Nov 2015 10:02:11 +1000
> Subject: [PATCH 1/3] gnu: Add ruby-systemu.

> * gnu/packages/ruby.scm (ruby-systemu): New variable.

[...]

> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'check 'patch-and-set-version
> +           (lambda _
> +             (setenv "VERSION" ,version)
> +             #t)))))

That’s an odd phase name; why “patch”?  Is setting the environment
variable the only way to set the version or would a make-flag work here,
too?  (I haven’t checked if the ruby-build-system respects make-flags.)

The rest looks good to me.  Thanks!

~~ Ricardo