Re: [PATCH 2/2] gnu: Add espeak.

[Ludovic Courtès]

Leo Famulari <address@hidden> skribis:

> * gnu/packages/audio.scm (espeak): New variable.

If you think eSpeak-ng is not ready yet, or is sufficiently different,
it’s OK to package eSpeak.

> +    (native-inputs
> +     `(("unzip" ,unzip)))
> +    (inputs
> +      `(("sonic" ,sonic)

The “unzip” line is misaligned.

> +        ("pulseaudio" ,pulseaudio)
> +        ("portaudio" ,portaudio)))

Dunno if it’s useful to have both, maybe someone more knowledgeable like
Ricardo can answer?

> +    (synopsis "Software speech synthesizer")
> +    (description "eSpeak is a compact software speech synthesizer for
> +English and other languages, for Linux and Windows.  eSpeak uses a
                              ^---------------------^
Remove.

In general, we don’t mention proprietary software, and we don’t mention
other OSes, free or not, portability etc., because that’s not what
matters from the viewpoint of an OS provider.

The rest LGTM!

Thanks,
Ludo’.