Re: [PATCH] import: Move beautify description from cran to utils. (was Re: [PATCH 6/6] gnu: Add emacs-slime.)

[Ricardo Wurmus]

Ben Woodcroft <address@hidden> writes:

> On 14/01/16 20:31, Ricardo Wurmus wrote:
>> This breaks two of the cran importer tests:
>>
>> (test-equal "beautify-description: use double spacing"
>>    "This is a package.  It is great.  Trust me Mr.  Hendrix."
>>    ((@@ (guix import cran) beautify-description)
>>     "This is a package. It is great. Trust me Mr. Hendrix."))
>>
>> (test-equal "beautify-description: transform fragment into sentence"
>>    "This package provides a function to establish world peace"
>>    ((@@ (guix import cran) beautify-description)
>>     "A function to establish world peace"))
>>
>> How about moving these tests elsewhere?  (Or should they be removed?)
>
> Ah, sorry. Should they be moved to a new file tests/import-utils? Why do 
> you suggest that they should be removed?

I don’t have any preference for a name.  “tests/import-utils” sounds
good to me.  If we can keep (and later enhance) the tests it would
obviously be better.  (I just meant that I wouldn’t be too sad if they
were removed for whatever reasons.)

Would you like to submit a patch to add tests/import-utils (including
adding it to SCM_TESTS in Makefile.am) and move these two test cases
there?

~~ Ricardo