Re: [PATCH] Add audit.

[Ludovic Courtès]

Ricardo Wurmus <address@hidden> skribis:

> the tests for this package cannot easily be fixed by
>
>        #:phases
>        (modify-phases %standard-phases
>          (add-after 'unpack 'fix-tests
>            (lambda _
>              (substitute* "auparse/test/auparse_test.ref"
>                (("\\(root\\)") "(unknown(0))"))
>              #t)))
>
> because for *some* of them “(root)” is returned (while for *most* of
> them its “(unknown(0))”).  Ideas on how to fix the tests are very
> welcome!

How does it get that info?

One thing to know is that /etc/passwd in the build environment contains
only two entries, and no entry for root/0; quoth build.cc:

--8<---------------cut here---------------start------------->8---
    writeFile(chrootRootDir + "/etc/passwd",
        (format(
            "nixbld:x:%1%:%2%:Nix build user:/:/noshell\n"
            "nobody:x:65534:65534:Nobody:/:/noshell\n")
            % (buildUser.enabled() ? buildUser.getUID() : getuid())
            % (buildUser.enabled() ? buildUser.getGID() : getgid())).str());
--8<---------------cut here---------------end--------------->8---

Thus, getpwuid(0) and getpwnam("root") both fail.

> From c4948bc06b30e4e55810b82cc458cd6a429b6f80 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Wed, 13 Jan 2016 16:00:06 +0100
> Subject: [PATCH] gnu: Add audit.
>
> * gnu/packages/admin.scm (audit): New variable.

[...]

> +    (synopsis "Userspace component to the Linux auditing system")

I’d write “User-space”.

> +    (description
> +     "auditd is the userspace component to the Linux auditing system.  It's

Maybe something like: “… to the Linux auditing system, which allows
logging of system calls made by user-land processes.”

Would be nice if we could fix those tests before pushing it.

Thanks,
Ludo’.