Re: 2 patches

[Leo Famulari]

On Thu, Jan 21, 2016 at 10:53:56AM +0200, Efraim Flashner wrote:
> I've been holding on to these for a bit, waiting to integrate them before
> submitting them.
> 
> cmocka: This is supposed to be used by mpv for running the tests, but the
> tests fail. Since mpv works I wasn't super motivated to try to get it to
> work, but I'm guessing other programs might also use it.
> 
> python-efl: There are a couple of programs that rely on this, none of which
> are packaged in guix (obviously). The one that I can think of is econnman, an
> enlightenment front-end to connman, which I was unable to determine if it had
> been absorbed by the enlightenemnt codebase in the time since econnman's last
> release.
> 
> -- 
> Efraim Flashner   <address@hidden>   אפרים פלשנר
> GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
> Confidentiality cannot be guaranteed on emails sent or received unencrypted

> From 1db7bfc722c0a486cc10cae7853a81484bfb41bc Mon Sep 17 00:00:00 2001
> From: Efraim Flashner <address@hidden>
> Date: Mon, 21 Dec 2015 11:11:01 +0200
> Subject: [PATCH 1/2] gnu: Add cmocka.
> 
> * gnu/packages/video.scm (cmocka): New variable.
> ---
>  gnu/packages/video.scm | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)

Is it specific to video programs? Otherwise, I think it should go
somewhere else. How about check.scm?

> +(define-public cmocka

[...]

> +    (arguments
> +     `(#:tests? #f)) ; No test target

Ironic!

> From 53336fe873bc639bc2ed65186384e9d6ca7ed34f Mon Sep 17 00:00:00 2001
> From: Efraim Flashner <address@hidden>
> Date: Sun, 15 Nov 2015 13:54:22 +0200
> Subject: [PATCH] gnu: Add python-efl.
> 
> * gnu/packages/enlightenment.scm (python-efl, python2-efl): New variables.
> ---
>  gnu/packages/enlightenment.scm | 40 +++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 39 insertions(+), 1 deletion(-)

[...]

> +    (synopsis "Python bindings for EFL")
> +    (description
> +     "PYTHON-EFL are the python bindings for the whole EFL stack (eo, evas,
                                                          
Can you expand this acronym EFL in the description? ------^

> +ecore, edje, emotion, ethumb and elementary).")
> +    (license (list license:lgpl3 license:gpl3))))

Perhaps add a short note explaining what parts are under which license?

Otherwise they both look good to me.

> +
> +(define-public python2-efl
> +  (package-with-python2 python-efl))
> -- 
> 2.7.0
>