[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [SHEPHERD] [PATCH] service: Improve 'service-list'.
From: |
Alex Kost |
Subject: |
Re: [SHEPHERD] [PATCH] service: Improve 'service-list'. |
Date: |
Mon, 25 Jan 2016 11:39:33 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Ludovic Courtès (2016-01-25 00:20 +0300) wrote:
> Alex Kost <address@hidden> skribis:
[...]
>> [PATCH 1/5] service: Rename 'services' variable to '%services'.
>> [PATCH 2/5] service: Improve style of 'for-each-service'.
>>
>> [PATCH 3/5] service: 'service-list' returns unique services.
>>
>> Without this change, if the root service provides 2 names, 'herd status'
>> would display:
>>
>> Started: (root root)
>> Stopped: ()
>>
>> [PATCH 4/5] service: Add docstring to 'lookup-services'.
>> [PATCH 5/5] Rename 'dmd' service to 'root'.
>
> Excellent! I’ve pushed all 5 patches.
Ah, I'm late :-) I suddenly realized that for the 3rd patch it would be
better to use 'lookup-canonical-service' instead of 'delete-duplicates'.
It is guaranteed that there will be no duplicates since services have a
single canonical name, so for each name from %services hash-table there
will be either zero or one service with this canonical name.
(Hm, I probably didn't describe it well, but I hope it's clear enough)
So would it be OK to push the attached patch?
> While I was at it, I’ve added Mathieu and you as committers.
Thank you!
0001-service-Improve-service-list.patch
Description: Text Data
- [SHEPHERD] [PATCH 0/5] Replace 'dmd' service with 'root/shepherd'., Alex Kost, 2016/01/24
- [PATCH 2/5] service: Improve style of 'for-each-service'., Alex Kost, 2016/01/24
- [PATCH 3/5] service: 'service-list' returns unique services., Alex Kost, 2016/01/24
- [PATCH 4/5] service: Add docstring to 'lookup-services'., Alex Kost, 2016/01/24
- [PATCH 1/5] service: Rename 'services' variable to '%services'., Alex Kost, 2016/01/24
- [PATCH 5/5] Rename 'dmd' service to 'root'., Alex Kost, 2016/01/24
- Re: [SHEPHERD] [PATCH 0/5] Replace 'dmd' service with 'root/shepherd'., Ludovic Courtès, 2016/01/24