Re: [PATCH 3/7] emacs: Add 'guix-browse-license-url' command.

[Alex Kost]

Ludovic Courtès (2016-01-23 20:13 +0300) wrote:

> Alex Kost <address@hidden> skribis:
>
>> * emacs/guix-main.scm (license-names, license-name->license)
>>   (license-name->uri): New procedures.
>> * emacs/guix-read.el (guix-license-names, guix-read-license-name): New
>>   procedures.
>> * emacs/guix-license.el: New file.
>> * emacs.am (ELFILES): Add it.
>
> [...]
>
>> +;;; Licenses
>
> I’d do:
>
>   (define %licenses
>     (delay (module-map thing from previous message…)))
>
>> +(define (license-names)
>> +  "Return a list of names of available licenses."
>> +  (map license-name %licenses))
>
> So here it’d become: (force %licenses).
>
> Other than that, LGTM!

I used delay/force and "(filter license? (module-map …))" advice from
the other message and pushed this patchset.  Thank you for your very
useful and informative comments!

-- 
Alex