guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 04/13] utils: Use '@' for separating package names and versio


From: Mathieu Lirzin
Subject: Re: [PATCH 04/13] utils: Use '@' for separating package names and version numbers.
Date: Mon, 25 Jan 2016 21:56:05 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Alex Kost <address@hidden> writes:

> Tremendous work!  How did you manage to find all these occurrences?

Thank you.  In fact I haven't followed any methodic step.  I have
started editing the heart of the thing (meaning
'package-name->name+version') then look where it was used. adapt the
code/docstring and so on.  Next I have used ‘M-x rgrep’ for suspicious
string like (version, "-", ...).  Finally when fixing something ‘make
check’ has helped me detecting regressions (or wrong tests).

> I know another insignificant place though :-) It's a docstring of
> 'guix-packages-by-name' command in "emacs/guix-ui-package.el" file.

I have updated my patch with this and fix the commit log.  Thanks.

--
Mathieu Lirzin

Attachment: 0001-utils-Use-for-separating-package-names-and-version-n.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]