[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [SHEPHERD] [PATCH] service: 'conflicts-with' returns a list of servi
|
From: |
Ludovic Courtès |
|
Subject: |
Re: [SHEPHERD] [PATCH] service: 'conflicts-with' returns a list of services. |
|
Date: |
Tue, 26 Jan 2016 17:56:27 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Alex Kost <address@hidden> skribis:
> From 9ce0f8b9ba720d21eca43fdb9b2ce749079a305b Mon Sep 17 00:00:00 2001
> From: Alex Kost <address@hidden>
> Date: Tue, 26 Jan 2016 12:12:41 +0300
> Subject: [PATCH] service: 'conflicts-with' returns a list of services.
>
> This fixes a regression introduced in commit
> cb168150d4581ffbc357ab6cdcd45d59051ee821.
>
> If 'conflicts-with' returns a list of names, 'conflicts-with-running'
> fails because 'running?' cannot be applied to a symbol.
>
> * modules/shepherd/service.scm (conflicts-with): Return a list of
> services instead of names.
> (start): Adjust accordingly.
Good catch, LGTM.
We should add tests for conflict handling.
Ludo’.