[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 06/13] build: Generate man pages after compiling guile object
From: |
Mathieu Lirzin |
Subject: |
Re: [PATCH 06/13] build: Generate man pages after compiling guile objects. |
Date: |
Thu, 28 Jan 2016 16:44:54 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Hi Eric,
Eric Bavier <address@hidden> writes:
> Here's my rough first take at this. It uses the status 77 convention
> to update a sentinel file and selectively run help2man.
>
> I realize the silent rule output isn't yet polished.
I have pushed the reviewed patches. So now it is polished. :)
> From 038645a3d14cd10fdb37f94703e463d8f7a3241a Mon Sep 17 00:00:00 2001
> From: Eric Bavier <address@hidden>
> Date: Wed, 27 Jan 2016 20:31:04 -0600
> Subject: [PATCH] doc: Generate manpages after .go are compiled.
>
> * build-aux/compile-all.scm: Exit 77 if no files to compile.
> * Makefile.am (make-go): Rename target to make-go.stamp. Update if any
> files were successfully compiled.
> * doc.am (subcommand-manual-target): Add dependency on make-go.stamp.
> Run help2man only if script input is changed.
> ---
> Makefile.am | 12 +++++++++---
> build-aux/compile-all.scm | 1 +
> doc.am | 15 ++++++++++++---
> 3 files changed, 22 insertions(+), 6 deletions(-)
>
[...]
> diff --git a/doc.am b/doc.am
> index f15efcc..b3996d1 100644
> --- a/doc.am
> +++ b/doc.am
> @@ -106,9 +106,18 @@ doc/guix-daemon.1: nix/nix-daemon/guix-daemon.cc
>
> define subcommand-manual-target
>
> -doc/guix-$(1).1: guix/scripts/$(1).scm
> - -LANGUAGE= $(top_builddir)/pre-inst-env \
> - $(HELP2MAN) --output="$$@" "guix $(1)"
> +# Note: The dependency on make-go.stamp is to force these docs to be made
> only
> +# after all guile modules have been compiled, so that they are not compiled
> +# during this rule. But we only want to actually generate the manpages if
> the
> +# corresponding script source has been changed.
> +doc/guix-$(1).1: guix/scripts/$(1).scm make-go.stamp
> + -$(AM_V_at)case '$$?' in \
> + *$$<*) \
> + echo " GEN $$@"; \
> + LANGUAGE= $(top_builddir)/pre-inst-env \
> + $(HELP2MAN) --output="$$@" "guix $(1)" ;; \
> + *) : ;; \
> + esac
IIUC, there is a problem with adding ‘make-go.stamp’ as a prerequisite
here. Since building ‘.go’ files from the tarball will trigger the
rebuild of man pages.
Did I miss something?
--
Mathieu Lirzin
- [PATCH 01/13] tests: Use 'dummy-origin' for lint tests when possible., (continued)
- [PATCH 01/13] tests: Use 'dummy-origin' for lint tests when possible., Mathieu Lirzin, 2016/01/24
- [PATCH 05/13] packages: Use '@' in package record printers., Mathieu Lirzin, 2016/01/24
- [PATCH 03/13] lint: Rewrite 'check-patch-file-names'., Mathieu Lirzin, 2016/01/24
- [PATCH 06/13] build: Generate man pages after compiling guile objects., Mathieu Lirzin, 2016/01/24
- Re: [PATCH 06/13] build: Generate man pages after compiling guile objects., Ludovic Courtès, 2016/01/26
- Re: [PATCH 06/13] build: Generate man pages after compiling guile objects., Mathieu Lirzin, 2016/01/26
- Re: [PATCH 06/13] build: Generate man pages after compiling guile objects., Eric Bavier, 2016/01/28
- Re: [PATCH 06/13] build: Generate man pages after compiling guile objects.,
Mathieu Lirzin <=
- Re: [PATCH 06/13] build: Generate man pages after compiling guile objects., Eric Bavier, 2016/01/28
- Re: [PATCH 06/13] build: Generate man pages after compiling guile objects., Mathieu Lirzin, 2016/01/28
- Re: [PATCH 06/13] build: Generate man pages after compiling guile objects., Eric Bavier, 2016/01/29
- Re: [PATCH 06/13] build: Generate man pages after compiling guile objects., Mathieu Lirzin, 2016/01/29
- Re: [PATCH 06/13] build: Generate man pages after compiling guile objects., Eric Bavier, 2016/01/29
- Re: [PATCH 06/13] build: Generate man pages after compiling guile objects., Mathieu Lirzin, 2016/01/29
- Re: [PATCH 06/13] build: Generate man pages after compiling guile objects., Ludovic Courtès, 2016/01/31
[PATCH 08/13] build: Add 'DOT' silent rule., Mathieu Lirzin, 2016/01/24
[PATCH 11/13] build: Delete emacs/guix-autoloads.el when 'make clean'., Mathieu Lirzin, 2016/01/24