Re: [PATCH] gnu: Add libcanberra-gtk2.

[Ludovic Courtès]

Efraim Flashner <address@hidden> skribis:

> On Sat,  6 Feb 2016 19:48:44 +0100
> Fabian Harfert <address@hidden> wrote:
>
>> * gnu/packages/libcanberra.scm (libcanberra/gtk+-2): New variable.

[...]

>> +(define-public libcanberra/gtk+-2
>> +  (package (inherit libcanberra)
>> +    (name "libcanberra-gtk2")
>> +    (inputs
>> +     `(("alsa-lib" ,alsa-lib)
>> +       ("gstreamer" ,gstreamer)
>> +       ("gtk+" ,gtk+-2)
>> +       ("libltdl" ,libltdl)
>> +       ("libvorbis" ,libvorbis)
>> +       ("pulseaudio" ,pulseaudio)
>> +       ("udev" ,eudev)
>> +       ("sound-theme-freedesktop" ,sound-theme-freedesktop)))))
>> +
>>  (define-public sound-theme-freedesktop
>>    (package
>>      (name "sound-theme-freedesktop")
>
> gtk is the only different input between the two variants, how about just
> removing gtk from the list of inherited inputs and adding in gtk+-2?

Agreed.  Fabian: could you send an updated patch?  If you prefer one of
us could adjust your patch to do that.

Thanks,
Ludo’.