Re: [PATCH] gnu: Add slurm-llnl.

[Pjotr Prins]

Thanks for the review. This apparently a problematic package. Let's
try fix a few things at a time.

On Wed, Feb 10, 2016 at 10:04:47PM -0600, Eric Bavier wrote:
> >    #:use-module (guix download)
> > +  #:use-module (guix licenses)
> > +  #:use-module ((guix licenses) #:prefix license:)
> >    #:use-module (guix build-system gnu)
> >    #:use-module (gnu packages)

> >  (define-public parallel
> >    (package
> > @@ -47,3 +54,41 @@
> >  or more computers.  Jobs can consist of single commands or of scripts
> >  and they are executed on lists of files, hosts, users or other items.")
> >      (license gpl3+)))
>                 ^
> With the new 'license:' symbol prefix, all other licenses need to be
> adjusted.

I am under the impression one should fix one package at a time. What
is the policy anyway? With or without namespace? Without the namespace
there is a naming conflict between the openssl license and the openssl
package (in tls).

> > +
> > +(define-public slurm-llnl
> > +  (package
> > +   (name "slurm-llnl")
> 
> I think we should rather use "slurm-wlm" if we are trying to
> dissambiguate with the "Slurm the Realtime network interface monitor".

The website https://computing.llnl.gov/linux/slurm/ suggests
otherwise. Also archlinux took this name
https://aur.archlinux.org/packages/slurm-llnl/

> > +   (version "15-08-6-1")
> 
> Version 15.08.7  is now available.  I would prefer we use '.'s to
> separate version number components, and compute the uri string
> appropriately.

OK

> > +   (source (origin
> > +            (method url-fetch)
> > +            (uri (string-append 
> > "https://github.com/SchedMD/slurm/archive/slurm-";
> > +                                version ".tar.gz"))
> > +            (file-name (string-append name "-" version ".tar.gz"))
> > +            (sha256
> > +             (base32
> > +              "1h8al21blmrhma9r7qxkba2g5i74m3hrjc9a640j7px54szvg18v"))))
> > +   (inputs `(("openssl" ,openssl)
> > +             ("munge" ,munge)
> > +             ("perl" ,perl)
> > +             ("expect" ,expect)
> > +             ("python" ,python)
> > +             ("linux-pam" , linux-pam)))
> > +   (build-system gnu-build-system)
> > +   (arguments
> > +    `(#:configure-flags '("--enable-pam")
> > +      #:phases
> > +      (modify-phases %standard-phases
> > +       (add-before
> > +        'configure 'rewrite-usr-bin
> > +        (lambda* (#:key inputs #:allow-other-keys)
> > +                 (substitute* "./doc/html/shtml2html.py"
> > +                              (("#!/usr/bin/env python")
> > +                               (string-append "#!" (which "python3"))))
> 
> Is this shebang not handled by the patch-shebangs phase?

I added it because the build failed. I'll try again.

> > +                 (substitute* "src/common/env.c"
> > +                              (("/usr/bin/env") (which "env"))))))))
> > +   (home-page "http://www.schedmd.com/";)
> 
> How about "http://slurm.schedmd.com/";?

Sure. Arch does different.

> > +   (synopsis "Tool for cluster computing")
> 
> How about "Workload manager" to indicate what the tool does.

Arch has: Simple Linux Utility for Resource Management which is even
less descriptive ;). Besides, slurm runs on more environments.

> > +   (description
> > +    "Fault-tolerant, and highly scalable cluster management and job
> > +scheduling system for large and small clusters.")
> > +   (license license:openssl)))
> 
> According to the "License" section at http://www.schedmd.com/#repos
> and the COPYING file, it's GPLv2.

See next.

--